Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Implementation #23

Closed
ajnovice opened this issue Mar 6, 2018 · 5 comments
Closed

Pagination Implementation #23

ajnovice opened this issue Mar 6, 2018 · 5 comments
Milestone

Comments

@ajnovice
Copy link

ajnovice commented Mar 6, 2018

I didn't find any implementation for Pagination.
Do I have to implement the code for pagination or is there any other way?

@gtback
Copy link
Contributor

gtback commented Mar 12, 2018

Right now, this library doesn't handle pagination, but I would absolutely accept a pull request that adds it.

I haven't really thought through an implementation approach; I've used libraries like the various GitHub API ones that do this. We probably don't want to always return all the items from every page, but make it easy to fetch them on demand when iterating through the results, for instance. What do you think, @ajays91 ?

@ajnovice
Copy link
Author

I would love to do that and I also identified some minor bugs. First, I would fix the bugs in the coming weekend.

@gtback
Copy link
Contributor

gtback commented Mar 15, 2018

Thanks, @ajays91. That sounds good. We are currently working on fixes to #22 and #24, but if you have found other bugs, fixing them would be very much appreciated! 💯

@gtback
Copy link
Contributor

gtback commented Mar 15, 2018

Also, in case you weren't aware, you'll need to complete the OASIS CLA form prior to any pull requests getting merged. Thanks again!

@robincover
Copy link
Contributor

Ajay's CLA is on file. Thanks Greg and Ajay. -rcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants