Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback in "Range" for pagination requests #84

Merged
merged 3 commits into from
Sep 10, 2020

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Sep 10, 2020

implement equivalent changes as initially thought by @teizenman

Closes #82

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #84 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   94.89%   95.23%   +0.33%     
==========================================
  Files           8        8              
  Lines        1784     1845      +61     
==========================================
+ Hits         1693     1757      +64     
+ Misses         91       88       -3     
Impacted Files Coverage Δ
taxii2client/test/test_client_v20.py 100.00% <100.00%> (ø)
taxii2client/v20/__init__.py 91.08% <100.00%> (+0.94%) ⬆️
taxii2client/common.py 81.69% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3f4f0...b756f09. Read the comment docs.

@emmanvg emmanvg added this to the 2.2.2 milestone Sep 10, 2020
@emmanvg emmanvg merged commit 0f85f1c into oasis-open:master Sep 10, 2020
@emmanvg emmanvg deleted the 82pr-range-header branch September 10, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants