You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that this should ONLY apply to the internal gRPC client (e.g. for the oasis-node client gRPC protocol), not to any other uses of gRPC (like storage).
kostko
changed the title
Make gRPC client less strict when decoding
Make internal gRPC client less strict when decoding
Oct 16, 2020
I am against this as it is not possible to rule out unexpected behavior in the future due to default values in new fields that get added, and the same people that will complain about having to keep the client and core build in-sync will be the loudest to complain to us when something bad does happen.
SUMMARY
Current, the client gRPC protocol is not versioned (#1861) and for example, adding a new field makes the client fail with something like:
Since we are only using the client gRPC protocol between trusted parties, we could make the CBOR decoding less strict and ignore unknown fields.
ISSUE TYPE
The text was updated successfully, but these errors were encountered: