Merge pull request #2587 from oat-sa/fix/AUT-3916/throw-error-for-pro…

…perties-without-range

Properties without range will throw exception

model/import/ChecksumGenerator.php

@@ -23,6 +23,7 @@
 namespace oat\taoQtiItem\model\import;
 
 use core_kernel_classes_Property as Property;
+use InvalidArgumentException;
 use oat\taoBackOffice\model\lists\ListService;
 
 class ChecksumGenerator
@@ -36,6 +37,15 @@ public function __construct(ListService $listService)
 
     public function getRangeChecksum(Property $property): string
     {
+        if ($property->getRange() === null) {
+            throw new InvalidArgumentException(
+                sprintf(
+                    'Property %s does not have range set. Only properties with range can have checksum',
+                    $property->getUri()
+                )
+            );
+        }
+
         $labels = [];
         foreach ($this->listService->getListElements($property->getRange()) as $listEntry) {
             $labels[] = strtolower($listEntry->getLabel());

test/unit/model/import/ChecksumGeneratorTest.php

@@ -25,7 +25,7 @@
 use core_kernel_classes_Class as ClassResource;
 use core_kernel_classes_Property as Property;
 use core_kernel_classes_Resource as Resource;
-use oat\generis\model\data\Ontology;
+use InvalidArgumentException;
 use oat\taoBackOffice\model\lists\ListService;
 use oat\taoQtiItem\model\import\ChecksumGenerator;
 use PHPUnit\Framework\TestCase;
@@ -74,4 +74,16 @@ public function testGetRangeChecksum(): void
             $this->checksumGenerator->getRangeChecksum($this->propertyMock)
         );
     }
+
+    public function testThrowExceptionOnPropertyWithoutRange(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage(
+            'Property propertyUri does not have range set. Only properties with range can have checksum'
+        );
+        $this->propertyMock->method('getRange')->willReturn(null);
+        $this->propertyMock->method('getUri')->willReturn('propertyUri');
+
+        $this->checksumGenerator->getRangeChecksum($this->propertyMock);
+    }
 }