fix: unique identifiers #2607
Merged
fix: unique identifiers #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielfs7
reviewed
Nov 6, 2024
gabrielfs7
reviewed
Nov 6, 2024
| $uniqueIdentifier = $this->resourceUniqueIdRetriever->retrieve($originalResource); | ||
|
|
||
| if ($uniqueIdentifier === null) { | ||
| $this->logger->info(sprintf('Cannot retrieve unique identifier for item %s', $originalResource->getUri())); |
There was a problem hiding this comment.
- This should be an error exception. If this feature flag is active why would an Item/Test be missing this id and we masking the error?
gabrielfs7
reviewed
Nov 6, 2024
gabrielfs7
approved these changes
Nov 6, 2024
gabrielfs7
reviewed
Nov 6, 2024
|
|
||
| use function Symfony\Component\DependencyInjection\Loader\Configurator\service; | ||
|
|
||
| class QtiIdentifierServiceProvider implements ContainerServiceProviderInterface |
There was a problem hiding this comment.
Can we call it QtiServiceProvider to avoid having to create new providers later for the same namespace qti
shpran
force-pushed
the
fix/hkd-6/unique-identifiers
branch
from
6739e60 to
459efe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for unique identifiers + removing unnecessary classes