Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ADF-1788/Add the translation list UI #480

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Oct 14, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1788

Summary

Add the action for managing the list of translations.

image

Details

Add the translate action and wire it with the translation component and service.

How to test

  • checkout the branch: git checkout -t origin/feature/ADF-1788/translation-list-ui
  • make sure to also install the companion PR (feat/HKD-6/integration on other repos)
  • select a test and see the translate button
  • click the translate button (note: you need the test to be ready for translation, otherwise, the component will only show a placeholder message)

The following feature flags will also be needed:

FEATURE_FLAG_TRANSLATION_ENABLED=true
FEATURE_FLAG_UNIQUE_NUMERIC_QTI_IDENTIFIER=true

@jsconan jsconan requested review from gabrielfs7 and shaveko October 14, 2024 10:00
Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works with no issues

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@jsconan jsconan merged commit c2f4adf into feat/HKD-6/integration Oct 14, 2024
@jsconan jsconan deleted the feature/ADF-1788/translation-list-ui branch October 14, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants