From 7d5137ff907459bdda8b4a27be81ea79f6f81aaa Mon Sep 17 00:00:00 2001 From: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> Date: Tue, 2 Jul 2024 10:14:52 -0400 Subject: [PATCH] Update cache keys in `test-inputs.yml` It's always caching. Or DNS. This time it was caching. A while back, we changed the default cache key prefix from empty-string to `semver` so that our cache key names don't start with a dash, since users found that confusing. We should have updated these tests accordingly at the time, but we did not. So how did the PR with the change pass? It used the caches from older runs of the same job which used the old names. When those caches expired and were GC'd by GitHub, the jobs started failing. This is what broke CI for #77. This PR will fix it. --- .github/workflows/test-inputs.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test-inputs.yml b/.github/workflows/test-inputs.yml index 0e2ab73..3e15c31 100644 --- a/.github/workflows/test-inputs.yml +++ b/.github/workflows/test-inputs.yml @@ -286,9 +286,9 @@ jobs: path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache fail-on-cache-miss: true lookup-only: true - key: -${{ github.job }} + key: semver-${{ github.job }} restore-keys: | - -${{ github.job }} + semver-${{ github.job }} - name: Fail if the toolchain used by the action is invalid if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }} run: | @@ -329,9 +329,9 @@ jobs: path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache fail-on-cache-miss: true lookup-only: true - key: -${{ github.job }} + key: semver-${{ github.job }} restore-keys: | - -${{ github.job }} + semver-${{ github.job }} - name: Fail if the toolchain used by the action is invalid if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }} run: | @@ -372,9 +372,9 @@ jobs: path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache fail-on-cache-miss: true lookup-only: true - key: -${{ github.job }} + key: semver-${{ github.job }} restore-keys: | - -${{ github.job }} + semver-${{ github.job }} - name: Fail if the toolchain used by the action is invalid if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'beta') }} run: |