Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom git configurations that rewrite HTTPS to SSH #295

Open
theduke opened this issue Jan 17, 2023 · 2 comments
Open

Support custom git configurations that rewrite HTTPS to SSH #295

theduke opened this issue Jan 17, 2023 · 2 comments
Labels
C-enhancement Category: raise the bar on expectations

Comments

@theduke
Copy link

theduke commented Jan 17, 2023

Steps to reproduce the bug with the above code

With a custom Git config that rewrites https to ssh cargo semver-checks check-release fails .

~/.config/git/config:

[url "git@github.com:"]
	insteadOf = "https://github.com/"

Actual Behaviour

Error: unsupported URL protocol; class=Net (12)

Caused by:
    unsupported URL protocol; class=Net (12)

Expected Behaviour

It works...

Generated System Information

Software version

cargo-semver-checks 0.15.2

cargo version

> cargo -V
cargo 1.64.0 (387270bc7 2022-09-16)

Build Configuration

No response

Additional Context

No response

@theduke theduke added the C-bug Category: doesn't meet expectations label Jan 17, 2023
@tonowak
Copy link
Collaborator

tonowak commented Jan 17, 2023

Possibly related: #272

@obi1kenobi
Copy link
Owner

I think this is sadly blocked on upstream issues: frewsxcv/rust-crates-index#37 which is itself caused by rust-lang/git2-rs#600

Sadly, not much we can do about them short of implementing SSH support ourselves instead of using the upstream crates, which doesn't seem like a good idea.

As soon as the upstream crates add SSH support, a cargo update on our end will fix it for cargo-semver-checks too. Alternatively, since this problem is fixed in cargo, merging our tool into cargo should fix the problem too. Linking #61 for that.

@obi1kenobi obi1kenobi added C-enhancement Category: raise the bar on expectations and removed C-bug Category: doesn't meet expectations labels Jan 23, 2023
@obi1kenobi obi1kenobi changed the title Git Config HTTP to SSH: Unsupported URL Protocol Support custom git configurations that rewrite HTTPS to SSH Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: raise the bar on expectations
Projects
None yet
Development

No branches or pull requests

3 participants