Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running cargo semver-checks with no other arguments should default to checking #414

Closed
Lokathor opened this issue Mar 8, 2023 · 5 comments
Closed

Running cargo semver-checks with no other arguments should default to checking #414

Lokathor opened this issue Mar 8, 2023 · 5 comments
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@Lokathor
Copy link

Lokathor commented Mar 8, 2023

Describe your use case

I ran cargo semver-checks and it said i needed to pick a command or argument.

Describe the solution you'd like

Instead it should "do the right thing" and just do the checks if no command or argument is provided.

Alternatives, if applicable

No response

Additional Context

No response
@Lokathor Lokathor added the C-enhancement Category: raise the bar on expectations label Mar 8, 2023
@obi1kenobi
Copy link
Owner

100% agreed. Originally, I thought we might have multiple subcommands, but that turned out to not be the case and I've even considered deprecating check-release as a subcommand instead of just running it by default. I'm still not sure if we should go that far, but certainly running check-release by default would be an improvement.

If you'd be open to putting together a PR for this, I'd be thrilled to merge it.

@obi1kenobi obi1kenobi added E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Mar 8, 2023
@obi1kenobi
Copy link
Owner

Related to: #86 (comment)

@obi1kenobi obi1kenobi mentioned this issue Mar 22, 2023
Merged
4 tasks
@obi1kenobi obi1kenobi mentioned this issue May 29, 2023
Merged
@era
Copy link
Contributor

era commented May 30, 2023

@obi1kenobi I can send a PR changing the behaviour to run check-release by default.

@obi1kenobi
Copy link
Owner

Sounds great, thank you!

@era era mentioned this issue May 30, 2023
Merged
@obi1kenobi
Copy link
Owner

Fixed in #459 and shipped already, just forgot to close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@era @obi1kenobi @Lokathor