Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed archived k8s reference #1325

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Nov 2, 2023

Proposed Change

Removed reference to archived Kubernetes repo.

Checklist
  • Changes are tested
  • CI has passed

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
@cpheps cpheps requested review from andykellr and jsirianni November 2, 2023 11:46
@cpheps cpheps requested a review from a team as a code owner November 2, 2023 11:46
@BinaryFissionGames
Copy link
Contributor

This repo is also referenced in docs/getting-started.md and config/google_cloud_exporter/kubernetes/README.md.

(Side note, docs/getting-started.md seems outdated and like it was written for a different format, we might want to rework that one in the future)

@cpheps
Copy link
Contributor Author

cpheps commented Nov 2, 2023

(Side note, docs/getting-started.md seems outdated and like it was written for a different format, we might want to rework that one in the future)

Good call I'll create a ticket for new sprint to clean this up.

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
@cpheps
Copy link
Contributor Author

cpheps commented Nov 2, 2023

Removed the additional references. I'm unsure if the kubernetes deployment example still makes sense with that missing.

@BinaryFissionGames
Copy link
Contributor

Removed the additional references. I'm unsure if the kubernetes deployment example still makes sense with that missing.

It seems to me like it was just a link to that repo for the example config, basically. So we should probably just remove that whole kubernetes directory.

@cpheps
Copy link
Contributor Author

cpheps commented Nov 2, 2023

Removed the additional references. I'm unsure if the kubernetes deployment example still makes sense with that missing.

It seems to me like it was just a link to that repo for the example config, basically. So we should probably just remove that whole kubernetes directory.

@jsirianni Can you give your input here. I'm happy to remove it but I want to double check on the intent of that doc.

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
@cpheps cpheps requested review from BinaryFissionGames and removed request for andykellr November 6, 2023 16:31
@cpheps cpheps merged commit 6fbf4e4 into release/v1.39.0 Nov 6, 2023
12 checks passed
@cpheps cpheps deleted the chore/remove-k8s-doc branch November 6, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants