feat: Add default HTTP log receiver #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
force-pushed
the
feat/http-receiver
branch
from
f4a5a2f to
542b084
Compare
schmikei
reviewed
Nov 8, 2023
dpaasman00
force-pushed
the
feat/http-receiver
branch
from
5001091 to
28ed8dc
Compare
cpheps
reviewed
Nov 9, 2023
receiver/httpreceiver/config.go
Outdated
| // Config defines the configuration for an HTTP receiver | ||
| type Config struct { | ||
| Path string `mapstructure:"path"` | ||
| ServerSettings *confighttp.HTTPServerSettings `mapstructure:"server"` |
There was a problem hiding this comment.
Small recommendation here:
Suggested change
| ServerSettings *confighttp.HTTPServerSettings `mapstructure:"server"` | |
| ServerSettings *confighttp.HTTPServerSettings `mapstructure:",squash"` |
This way we don't need the extra server key when specifying endpoint/tls. I think this is the usual pattern with this struct (e.g. https://github.com/open-telemetry/opentelemetry-collector/blob/2a9d870a57038cb228ef20e7620f18a93c92b9d3/receiver/otlpreceiver/config.go#L25)
There was a problem hiding this comment.
oh yea perfect, didn't realize i could do that
BinaryFissionGames
approved these changes
Nov 9, 2023
schmikei
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
This PR adds a new receiver to the bindplane-agent which serves as a default HTTP log receiver. In actuality this was created for the sole purpose of ingesting logs from the Datadog-Agent. The receiver is made and described as a "default HTTP receiver" but the main focus of it is for this specific use case. As a result there are likely several limitations that prevent it from being a "default HTTP log receiver", but that is okay for the time being.
The correct and eventual solution for this use case and others like it is creating an HTTP input operator for Stanza and then making a receiver built around that, similar to the TCPLog receiver and Stanza TCP input operator. However that approach was not taken because we needed a solution for the Datadog-Agent use case quickly and the Stanza HTTP operator would take too long to realize.
Checklist