feat(loggroupgenerator): add otel #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the necessary OTEL instrumentation to our utility script. This is an absolutely insane amounts of dependencies (dynamodb?!) and boilerplate. The one nice thing is, as currently coded, all configuration can be done via env vars, e.g: ``` export OTEL_SERVICE_NAME=loggroupgenerator export OTEL_TRACES_EXPORTER=otlp export OTEL_EXPORTER_OTLP_ENDPOINT=https://157675308050.collect.observe-eng.com/v1/otel export OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf export OTEL_EXPORTER_OTLP_HEADERS="Authorization=Bearer <token>" ``` This means we can very easily export to stdout as well: ``` export OTEL_TRACES_EXPORTER=console ```
|
|
obs-gh-colinhutchinson
approved these changes
Dec 6, 2023
i hate it, it pulls in the entire otel ecosystem and then some. awful. |
|
🎉 This PR is included in version 1.5.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the necessary OTEL instrumentation to our utility script. This is an absolutely insane amounts of dependencies (dynamodb?!) and boilerplate. The one nice thing is, as currently coded, all configuration can be done via env vars, e.g:
This means we can very easily export to stdout as well: