fix(subscriber): set role ARN #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/role-arn-subscriber
branch
2 times, most recently
from
042ec2f
to
c68d29f
Compare
We need to allow iam:PassRole for the subscription lambda for the case where the destination is a Firehose Delivery Stream. We currently do not adequately capture this functionality because we never test Firehose as a destination. We'll have to fix that with further integration testing in the collection stack.
jta
force-pushed
the
joao/role-arn-subscriber
branch
from
c68d29f
to
ac49856
Compare
We were not correctly configuring the role ARN when setting a subscription filter. This is only necessary when the destination is a Kinesis Firehose delivery stream. Added unit test to verify the role ARN is passed to cloudwatchlogs:PutSubscriptionFilter
jta
force-pushed
the
joao/role-arn-subscriber
branch
from
ac49856
to
abe8bd5
Compare
obs-gh-colinhutchinson
approved these changes
Dec 13, 2023
|
🎉 This PR is included in version 1.5.0-beta.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not correctly configuring the role ARN when setting a subscription filter. This is only necessary when the destination is a Kinesis Firehose delivery stream. Added unit test to verify the role ARN is passed to cloudwatchlogs:PutSubscriptionFilter