Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscriber): use iam:PassRole for Lambda #135

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

jta
Copy link
Contributor

@jta jta commented Dec 12, 2023

We need to allow iam:PassRole for the subscription lambda for the case where the destination is a Firehose Delivery Stream. We currently do not adequately capture this functionality because we never test Firehose as a destination. We'll have to fix that with further integration testing in the collection stack.

We need to allow iam:PassRole for the subscription lambda for the case
where the destination is a Firehose Delivery Stream. We currently do not
adequately capture this functionality because we never test Firehose as
a destination. We'll have to fix that with further integration testing
in the collection stack.
@jta jta merged commit f4c98ee into main Dec 13, 2023
13 checks passed
@jta jta deleted the joao/role-template branch December 13, 2023 17:03
Copy link

🎉 This PR is included in version 1.5.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants