fix(forwarder): cap number of concurrency SQS tasks #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/cap-max-concurrency
branch
2 times, most recently
from
2e9e93d
to
7bc83ea
Compare
The forwarder function processes SQS tasks concurrently. By default this value was previously unbounded, which would cause significant delay when redriving a Dead Letter Queue. This commit changes the default to be set to the runtime number of CPUs, which allows the behaviour to scale with the amount of memory allocated to the lambda function.
jta
force-pushed
the
joao/cap-max-concurrency
branch
from
7bc83ea
to
a1d4e04
Compare
obs-gh-abhishekrao
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forwarder function processes SQS tasks concurrently. By default this value was previously unbounded, which would cause significant delay when redriving a Dead Letter Queue.
This commit changes the default to be set to the runtime number of CPUs, which allows the behaviour to scale with the amount of memory allocated to the lambda function.