Skip to content

Commit

Permalink
feat: use relative stack location (#6)
Browse files Browse the repository at this point in the history
* feat: use relative stack location

SAM will handle uploading the stacks to an S3 bucket for us, which seems
more appropriate than trying to figure out how to dynamically load
the appropriate application Id.

* fix: ignore the W3002 lint rule

---------

Co-authored-by: Colin Hutchinson <colin.hutchinson@observeinc.com>
  • Loading branch information
jta and obs-gh-colinhutchinson authored Oct 5, 2023
1 parent a294975 commit 1164daf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 2 additions & 0 deletions .cfnlintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ignore_checks:
- W3002
8 changes: 2 additions & 6 deletions apps/collection/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,7 @@ Resources:
Forwarder:
Type: AWS::Serverless::Application
Properties:
Location:
ApplicationId: arn:aws:serverlessrepo:us-east-1:739672403694:applications/observe-forwarder
SemanticVersion: 0.0.5
Location: ../forwarder/template.yaml
NotificationARNs:
- !Ref Topic
Parameters:
Expand Down Expand Up @@ -181,9 +179,7 @@ Resources:
DependsOn: Forwarder
Condition: EnableConfig
Properties:
Location:
ApplicationId: arn:aws:serverlessrepo:us-east-1:739672403694:applications/observe-aws-config
SemanticVersion: 0.0.4
Location: ../config/template.yaml
NotificationARNs:
- !Ref Topic
Parameters:
Expand Down

0 comments on commit 1164daf

Please sign in to comment.