fix(collection): append additional bucket and topic sources

A user may specify additional S3 buckets and SNS topics to be able to subscribe to. Append them to the S3 bucket and SNS topic created in our collection stack. Sadly, cloudformation makes it shockingly convoluted to append a string to a list.
observeinc · Oct 4, 2023 · 1c45353 · 1c45353
1 parent 80511dc
commit 1c45353
Showing 1 changed file with 23 additions and 3 deletions.
diff --git a/apps/collection/template.yaml b/apps/collection/template.yaml
@@ -19,7 +19,7 @@ Metadata:
           default: Required parameters
         Parameters:
           - DataAccessPointArn
-          - DestinationArn
+          - DestinationUri
       - Label:
           default: Components
         Parameters:
@@ -74,6 +74,12 @@ Conditions:
   UseStackName: !Equals
     - !Ref NameOverride
     - ""
+  EmptySourceBucketNames: !Equals
+    - !Join [ ",", !Ref SourceBucketNames ]
+    - ""
+  EmptySourceTopicArns: !Equals
+    - !Join [ ",", !Ref SourceTopicArns ]
+    - ""
 
 Resources:
   Topic:
@@ -140,8 +146,22 @@ Resources:
       Parameters:
         DataAccessPointArn: !Ref DataAccessPointArn
         DestinationUri: !Ref DestinationUri
-        SourceBucketNames: !Ref Bucket
-        SourceTopicArns: !Ref Topic
+        SourceBucketNames: !If
+          - EmptySourceBucketNames
+          - [ !Ref Bucket ]
+          - !Split
+            - ","
+            - !Sub
+              - "${Bucket},${buckets}"
+              - buckets: !Join [ ",", !Ref SourceBucketNames ]
+        SourceTopicArns: !If
+          - EmptySourceTopicArns
+          - [ !Ref Topic ]
+          - !Split
+            - ","
+            - !Sub
+              - "${Topic},${topics}"
+              - topics: !Join [ ",", !Ref SourceTopicArns ]
         NameOverride: !If
           - UseStackName
           - !Ref 'AWS::StackName'