fix(integration): support special characters in exec module #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit supports passing in environment variables with special characters to scripts in our "exec" module. The testcase has been modified to exemplify this functionality. Prior to this change, the testcase would fail due the variable getting clobbered after the first argument: ``` aws: error: argument --output: expected one argument ```
obs-gh-colinhutchinson
approved these changes
Nov 29, 2023
|
Will do in separate PR. I'm inclined to do +x for every case, because otherwise we run the risk of having different behavior between verbose and non-verbose runs (since we currently determine |
|
🎉 This PR is included in version 1.3.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit supports passing in environment variables with special characters to scripts in our "exec" module. The testcase has been modified to exemplify this functionality. Prior to this change, the testcase would fail due the variable getting clobbered after the first argument: