Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor router into mux #56

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: refactor router into mux #56

merged 1 commit into from
Nov 3, 2023

Conversation

jta
Copy link
Contributor

@jta jta commented Nov 3, 2023

Small refactor based off of work on future lambdas:

  • rename router.Handler to handler.Mux
  • embed Mux in Handler
  • move common logging functionality into the Mux

This change allows us to reduce some boilerplate when knocking out more functions.

Small refactor based off of work on future lambdas:

- rename `router.Handler` to `handler.Mux`
- embed Mux in Handler
- move common logging functionality into the Mux

This change allows us to reduce some boilerplate when knocking out more
functions.
Copy link
Contributor

@obs-gh-colinhutchinson obs-gh-colinhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible enough

@jta jta merged commit 5ed31ce into main Nov 3, 2023
4 of 5 checks passed
@jta jta deleted the joao/mux branch November 3, 2023 20:35
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 1.1.0-beta.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants