Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscriber): add configuration variables #79

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

jta
Copy link
Contributor

@jta jta commented Nov 10, 2023

No description provided.

Flesh out the two types of requests our handler will support. I'm
purposely keeping implementation light so as to make reviews more
tractable.
Copy link
Contributor

@obs-gh-colinhutchinson obs-gh-colinhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks correct. Would appreciate some tests but trust we'll fill those in

Base automatically changed from joao/discovery to main November 14, 2023 03:31
@jta jta merged commit 8bc15c8 into main Nov 14, 2023
6 checks passed
@jta jta deleted the joao/handler-config branch November 14, 2023 03:32
Copy link

🎉 This PR is included in version 1.1.0-beta.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants