Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscriber): introduce wildcard pattern #95

Merged
merged 1 commit into from
Nov 20, 2023
Merged

feat(subscriber): introduce wildcard pattern #95

merged 1 commit into from
Nov 20, 2023

Conversation

jta
Copy link
Contributor

@jta jta commented Nov 17, 2023

Previously we were treating the absence of patterns or prefixes to signify "subscribe all". Semantically this is quite confusing once you try to wire it into cloudformation, where we would like to have the presence of inputs gate the installation of our app.

This commit adds the ability to support wildcard on either logGroupNamePatterns or logGroupNamePrefixes. The subscriber cloudformation template is adjusted to still subscribe all log groups on install by default.

@jta jta force-pushed the joao/wildcard branch 3 times, most recently from 2ae238c to 4cc3d28 Compare November 18, 2023 04:34
Base automatically changed from joao/discovery-bis to main November 20, 2023 22:26
Previously we were treating the absence of patterns or prefixes to
signify "subscribe all". Semantically this is quite confusing once you
try to wire it into cloudformation, where we would like to have the
presence of inputs gate the installation of our app.

This commit adds the ability to support wildcard on either
`logGroupNamePatterns` or `logGroupNamePrefixes`. The subscriber
cloudformation template is adjusted to still subscribe all log groups on
install by default.
@jta jta merged commit 9c6ce40 into main Nov 20, 2023
6 checks passed
@jta jta deleted the joao/wildcard branch November 20, 2023 23:25
Copy link

🎉 This PR is included in version 1.2.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants