feat(subscriber): introduce wildcard pattern #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/wildcard
branch
3 times, most recently
from
2ae238c
to
4cc3d28
Compare
obs-gh-colinhutchinson
approved these changes
Nov 20, 2023
Previously we were treating the absence of patterns or prefixes to signify "subscribe all". Semantically this is quite confusing once you try to wire it into cloudformation, where we would like to have the presence of inputs gate the installation of our app. This commit adds the ability to support wildcard on either `logGroupNamePatterns` or `logGroupNamePrefixes`. The subscriber cloudformation template is adjusted to still subscribe all log groups on install by default.
|
🎉 This PR is included in version 1.2.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were treating the absence of patterns or prefixes to signify "subscribe all". Semantically this is quite confusing once you try to wire it into cloudformation, where we would like to have the presence of inputs gate the installation of our app.
This commit adds the ability to support wildcard on either
logGroupNamePatternsorlogGroupNamePrefixes. The subscriber cloudformation template is adjusted to still subscribe all log groups on install by default.