feat(firehose): allow creation of writer role #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/wildcard
branch
2 times, most recently
from
2ae238c
to
4cc3d28
Compare
obs-gh-colinhutchinson
suggested changes
Nov 20, 2023
There was a problem hiding this comment.
test failure looks like it's possibly relevant
https://github.com/observeinc/aws-sam-testing/actions/runs/6934334173/job/18862217805?pr=96#step:11:5831
It is convenient to create a role that has access to writing to the firehose we create within our app. We don't necessarily know what service will be assuming the role however. Gate the creation of such a role on the user providing a service.
obs-gh-colinhutchinson
approved these changes
Nov 21, 2023
|
🎉 This PR is included in version 1.2.0-beta.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is convenient to create a role that has access to writing to the firehose we create within our app. We don't necessarily know what service will be assuming the role however. Gate the creation of such a role on the user providing a service.