feat: Indy join class request page

[faucomte97]

This change is 

[SKairinos]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @faucomte97)

---

-- commits line 1 at r1:
general comment: need to update the PR name to follow semantic release conventions

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 6 at r1 (raw file):

import type { SessionMetadata } from "codeforlife/hooks"
import { Typography } from "@mui/material"
import { handleResultState } from "codeforlife/utils/api.tsx"

no file extension codeforlife/utils/api. Please remove file extensions from all imports

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 43 at r1 (raw file):

              details.
            </Typography>

delete blank line

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 44 at r1 (raw file):

            </Typography>

            <UpdateRequestingToJoinClassForm

RequestToJoinClassForm

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 45 at r1 (raw file):

            <UpdateRequestingToJoinClassForm
              indyUser={{

indyUser={user}

---

src/pages/studentJoinClass/RequestPending.tsx line 19 at r1 (raw file):

  const school = result.data

  if (!school) return <CircularProgress />

please use the util: handleResultState (this is what it's for)

Code quote:

  const result = useRetrieveSchoolQuery(user.requesting_to_join_class!.school)
  const school = result.data

  if (!school) return <CircularProgress />

---

src/pages/studentJoinClass/RequestPending.tsx line 44 at r1 (raw file):

        decision.
      </Typography>

delete blank line

---

src/pages/studentJoinClass/RequestPending.tsx line 46 at r1 (raw file):

      <Stack direction="row" spacing={2}>
        <Button

Please use LinkButton component instead.

import {LinkButton} from "codeforlife/components/router"

---

src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx line 21 at r1 (raw file):

  return (
    <>

delete. only one top-level component.

---

src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx line 51 at r1 (raw file):

          required
        />

delete blank line.

---

src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx line 53 at r1 (raw file):

        <Stack direction="row" spacing={2} paddingY={3}>
          <Button

Use LinkButton

[faucomte97]

Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @SKairinos)

---

-- commits line 1 at r1:

Previously, SKairinos (Stefan Kairinos) wrote…

general comment: need to update the PR name to follow semantic release conventions

Done.

---

src/pages/studentJoinClass/RequestPending.tsx line 19 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

please use the util: handleResultState (this is what it's for)

Done.

---

src/pages/studentJoinClass/RequestPending.tsx line 44 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

delete blank line

Done.

---

src/pages/studentJoinClass/RequestPending.tsx line 46 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

Please use LinkButton component instead.

import {LinkButton} from "codeforlife/components/router"

Done, also path was wrong.

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 6 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

no file extension codeforlife/utils/api. Please remove file extensions from all imports

Done.

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 43 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

delete blank line

Done.

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 44 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

RequestToJoinClassForm

Done.

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 45 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

indyUser={user}

😞

---

src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx line 21 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

delete. only one top-level component.

Done.

---

src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx line 51 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

delete blank line.

Done.

---

src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx line 53 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

Use LinkButton

Done.

[SKairinos]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 45 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

😞

Apologies. I forgot we were expanding the requesting_to_join_class field in portal. Then can just set it to

indyUser={{ id: user.id,  requesting_to_join_class: user.requesting_to_join_class.id }}

[SKairinos]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)

---

src/pages/studentJoinClass/RequestPending.tsx line 23 at r2 (raw file):

    useRetrieveSchoolQuery(user.requesting_to_join_class!.school),
    school => {
      return (

can just do

school => (
....
)

Code quote:

    school => {
      return (

[faucomte97]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)

---

src/pages/studentJoinClass/RequestPending.tsx line 23 at r2 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

can just do

school => (
....
)

Done.

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 45 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

Apologies. I forgot we were expanding the requesting_to_join_class field in portal. Then can just set it to

indyUser={{ id: user.id,  requesting_to_join_class: user.requesting_to_join_class.id }}

Still doesn't like it

[faucomte97]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)

---

src/pages/studentJoinClass/StudentJoinClass.tsx line 45 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Still doesn't like it

nvm, fixed with !

[SKairinos]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

[cfl-bot]

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀