-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cows to existing levels #1492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)
game/messages.py
line 944 at r2 (raw file):
"side roads too, so be careful not to hit them!" "<br><br>" "Hint: Cows don't like noise"
We need to update this then if we're updating the solution to actually use the general algorithm.
Code quote:
"Maybe there is a more efficient way than using the general algorithm "
"in this one? It looks like the cows have escaped when you get to the "
"side roads too, so be careful not to hit them!"
"<br><br>"
"Hint: Cows don't like noise"
game/migrations/0083_add_cows_to_existing_levels.py
line 56 at r2 (raw file):
).delete() LevelDecor.objects.bulk_create(
Could you please check with Laura / Rebecca to make sure that they are happy for the road decor to be actual road tiles, as opposed to the dirt path which is what is normally used for the farm levels? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
game/messages.py
line 944 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
We need to update this then if we're updating the solution to actually use the general algorithm.
Done.
game/migrations/0083_add_cows_to_existing_levels.py
line 56 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Could you please check with Laura / Rebecca to make sure that they are happy for the road decor to be actual road tiles, as opposed to the dirt path which is what is normally used for the farm levels? 🙏
Done. see
Codecov Report
@@ Coverage Diff @@
## master #1492 +/- ##
==========================================
+ Coverage 91.80% 91.87% +0.06%
==========================================
Files 106 107 +1
Lines 5603 5636 +33
==========================================
+ Hits 5144 5178 +34
+ Misses 459 458 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is