Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cows to existing levels #1492

Merged
merged 15 commits into from
Oct 16, 2023
Merged

feat: add cows to existing levels #1492

merged 15 commits into from
Oct 16, 2023

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Oct 11, 2023

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)


game/messages.py line 944 at r2 (raw file):

        "side roads too, so be careful not to hit them!"
        "<br><br>"
        "Hint: Cows don't like noise"

We need to update this then if we're updating the solution to actually use the general algorithm.

Code quote:

        "Maybe there is a more efficient way than using the general algorithm "
        "in this one? It looks like the cows have escaped when you get to the "
        "side roads too, so be careful not to hit them!"
        "<br><br>"
        "Hint: Cows don't like noise"

game/migrations/0083_add_cows_to_existing_levels.py line 56 at r2 (raw file):

    ).delete()

    LevelDecor.objects.bulk_create(

Could you please check with Laura / Rebecca to make sure that they are happy for the road decor to be actual road tiles, as opposed to the dirt path which is what is normally used for the farm levels? 🙏

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)


game/messages.py line 944 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

We need to update this then if we're updating the solution to actually use the general algorithm.

Done.


game/migrations/0083_add_cows_to_existing_levels.py line 56 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Could you please check with Laura / Rebecca to make sure that they are happy for the road decor to be actual road tiles, as opposed to the dirt path which is what is normally used for the farm levels? 🙏

Done. see

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1492 (3322032) into master (c0a33b7) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 3322032 differs from pull request most recent head 81151a6. Consider uploading reports for the commit 81151a6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1492      +/-   ##
==========================================
+ Coverage   91.80%   91.87%   +0.06%     
==========================================
  Files         106      107       +1     
  Lines        5603     5636      +33     
==========================================
+ Hits         5144     5178      +34     
+ Misses        459      458       -1     
Files Coverage Δ
game/end_to_end_tests/test_play_through.py 100.00% <100.00%> (ø)
game/messages.py 99.38% <100.00%> (ø)
...ame/migrations/0083_add_cows_to_existing_levels.py 100.00% <100.00%> (ø)
game/views/level_solutions.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@faucomte97 faucomte97 merged commit a57c0b3 into master Oct 16, 2023
3 checks passed
@faucomte97 faucomte97 deleted the cows_level_38 branch October 16, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants