Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler flags instead of attributes in stdlib.ml can be used with Dune 3.7.1 #1297

Open
gretay-js opened this issue Apr 10, 2023 · 0 comments

Comments

@gretay-js
Copy link
Contributor

Dune 3.7.1 includes the fix from ocaml/dune#7241. When we move to this dune, the attribute [@@@zero_alloc check] introduced by #1294 in ocaml/stdlib can be removed, and maybe [@@@ ocaml.flambda_o3] can be replace with a compiler flag. Using the attributes makes the diff with upstream bigger although not hard to maintian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant