Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rename Try_OCaml→Tutorials, --enable-tryocaml→--enable-tutorials #451

Merged
merged 1 commit into from
Feb 25, 2022
Merged

feat: Rename Try_OCaml→Tutorials, --enable-tryocaml→--enable-tutorials #451

merged 1 commit into from
Feb 25, 2022

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Nov 1, 2021 •
edited
Loading

  • Kind: enhancement

Description

  • Rename all relevant identifiers in the code, to avoid any ambiguity

  • learnocaml_main.ml: Keep CLI option --enable-tryocaml for backward-compatibility;
    Use a dedicated list of old option names.

Checklist

Note to maintainers

  • Read this wiki page
  • Make sure the PR has a milestone
  • Assign yourself before merging
  • (We can squash-merge 1-commit PRs; ensuring the header has a conventional-commit type and the footer says Close #…)

@erikmd erikmd added the kind: enhancement Enhancement to an existing user-facing feature. label Nov 1, 2021
@erikmd erikmd requested a review from yurug November 1, 2021 22:07
@erikmd
Copy link
Member Author

erikmd commented Nov 1, 2021

FTR: here is a screenshot of the homepage (in French) after building this PR.

2021-11-01_23-08-15_Screenshot_learn-ocaml_PR_451

@erikmd erikmd changed the title feat: Rename Try_OCaml→Tutorials, --enable-tryocaml→--enable-tutorials feat: Rename Try_OCaml→Tutorials, --enable-tryocaml→--enable-tutorials; Close #415 Nov 1, 2021
@erikmd erikmd assigned erikmd and yurug and unassigned erikmd Nov 1, 2021
@erikmd erikmd added this to the learn-ocaml 0.14.0 milestone Nov 1, 2021
yurug
yurug reviewed Jan 3, 2022
View reviewed changes
translations/fr.po Outdated Show resolved Hide resolved
@erikmd
feat: Rename Try_OCaml→Tutorials, --enable-tryocaml→--enable-tutorials
ef3cd53 
* Rename all relevant identifiers in the code, to avoid any ambiguity;

* learnocaml_main.ml: Keep CLI option --enable-tryocaml for
  backward-compatibility; Use a dedicated list of old option names

Close ocaml-sf#415
@erikmd erikmd changed the title feat: Rename Try_OCaml→Tutorials, --enable-tryocaml→--enable-tutorials; Close #415 feat: Rename Try_OCaml→Tutorials, --enable-tryocaml→--enable-tutorials Jan 7, 2022
@yurug yurug merged commit 9651160 into ocaml-sf:master Feb 25, 2022
@erikmd erikmd deleted the rename-try-ocaml branch March 4, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurug yurug yurug left review comments

Assignees

@yurug yurug

Labels
kind: enhancement Enhancement to an existing user-facing feature.
Projects
None yet
Milestone
learn-ocaml 0.14.0
Development

Successfully merging this pull request may close these issues.

Question: might we rename the Try OCaml button in Learn-OCaml's homepage?
2 participants
@erikmd @yurug