From fb118974f04786b5801823274132016175ef3a6a Mon Sep 17 00:00:00 2001
From: Rudi Grinberg <me@rgrinberg.com>
Date: Mon, 19 Feb 2024 02:36:00 -0800
Subject: [PATCH] fix: checking out git repos via rev_store (#10060)

We must create the target directory before extracting.

We can also use -C to instruct tar which directory to use rather than
doing chdir ourselves.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
---
 src/dune_pkg/rev_store.ml | 40 ++++++++++++++++++++++++---------------
 1 file changed, 25 insertions(+), 15 deletions(-)

diff --git a/src/dune_pkg/rev_store.ml b/src/dune_pkg/rev_store.ml
index 7631b97924f..03fb8eebbd0 100644
--- a/src/dune_pkg/rev_store.ml
+++ b/src/dune_pkg/rev_store.ml
@@ -620,6 +620,10 @@ module At_rev = struct
     let git = Lazy.force Vcs.git in
     let tar = Lazy.force tar in
     let temp_dir = Temp.create Dir ~prefix:"rev-store" ~suffix:rev in
+    Fiber.finalize ~finally:(fun () ->
+      let+ () = Fiber.return () in
+      Temp.destroy Dir temp_dir)
+    @@ fun () ->
     let archive_file = Path.relative temp_dir "archive.tar" in
     let stdout_to = Process.Io.file archive_file Process.Io.Out in
     let stderr_to = make_stderr () in
@@ -632,22 +636,28 @@ module At_rev = struct
     in
     let stdout_to = make_stdout () in
     let stderr_to = make_stderr () in
-    let+ () =
-      let args = [ "xf"; Path.to_string archive_file ] in
-      let+ (), exit_code =
-        Process.run ~dir:target ~display:Quiet ~stdout_to ~stderr_to failure_mode tar args
-      in
-      if exit_code <> 0
-      then
-        Code_error.raise
-          "tar returned non-zero exit code"
-          [ "exit code", Dyn.int exit_code
-          ; "dir", Path.to_dyn target
-          ; "tar", Path.to_dyn tar
-          ; "args", Dyn.list Dyn.string args
-          ]
+    (* We untar things into a temp dir to make sure we don't create garbage
+       in the build dir until we know can produce the files *)
+    let target_in_temp_dir = Path.relative temp_dir "dir" in
+    Path.mkdir_p target_in_temp_dir;
+    let args =
+      [ "xf"; Path.to_string archive_file; "-C"; Path.to_string target_in_temp_dir ]
+    in
+    let+ (), exit_code =
+      Process.run ~display:Quiet ~stdout_to ~stderr_to failure_mode tar args
     in
-    ()
+    if exit_code = 0
+    then (
+      Path.mkdir_p (Path.parent_exn target);
+      Path.rename target_in_temp_dir target)
+    else
+      Code_error.raise
+        "tar returned non-zero exit code"
+        [ "exit code", Dyn.int exit_code
+        ; "dir", Path.to_dyn target
+        ; "tar", Path.to_dyn tar
+        ; "args", Dyn.list Dyn.string args
+        ]
   ;;
 end