Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.15.1 release tracking #10427

Closed
14 tasks done
emillon opened this issue Apr 16, 2024 · 8 comments
Closed
14 tasks done

3.15.1 release tracking #10427

emillon opened this issue Apr 16, 2024 · 8 comments

Comments

@anmonteiro
Copy link
Collaborator

anmonteiro commented Apr 18, 2024

as reported in ocaml/opam-repository#25690 (comment), 3.15.1 breaks ocaml-protoc-plugin.

The offending set of changes seems to be #10432 / #10382. I reverted that change in the 3.15 branch and the cycle disappeared.

@jonahbeckford
Copy link
Collaborator

  • I haven't been able to finish testing out the changes between Dune 3.12.1 and 3.15.0 because of an unrelated block in the latest opam beta. If possible, would be nice if I can finish my DkML distribution testing before 3.15.1 goes out the door; it has a bunch of tests that Dune and Opam CI will not cover. I don't anticipate the opam beta blocker taking more than a day or two to resolve. I'll comment here when it is done, or just ping me.

@emillon
Copy link
Collaborator Author

emillon commented Apr 22, 2024

So there's indeed a regression on ocaml-protoc-plugin, including the last version. It looks like we were ignoring the cycle before, and now it's causing an issue. I filed #10447 for this but it any case that can't be fixed in a patch release so I'll cut 3.15.2 without it.

@jonahbeckford 3.15.1 has already been tagged, but your input is valuable for 3.15.2 which I'll prepare today. Let me know if you have any feedback about it.

@emillon
Copy link
Collaborator Author

emillon commented Apr 22, 2024

(amending what I said above, the fix will be to backport #10442)

@Leonidas-from-XIV
Copy link
Collaborator

However, given 3.15.1 is not merged, I think we should close that PR and replace it with 3.15.2.

@emillon
Copy link
Collaborator Author

emillon commented Apr 22, 2024

yes, I'll do that when the changelog etc have been merged

@jonahbeckford
Copy link
Collaborator

Thanks. I have long test cycles so I'm stuck testing Dune 3.15.0 for the time being. And since I haven't found any Windows blockers (yet) I'll probably ship DkML 2.1.1 with Dune 3.15.0.

I don't have the resources to increase the cadence, so (in hindsight) it is better just keeping with the status quo.

@emillon
Copy link
Collaborator Author

emillon commented Apr 23, 2024

OK, thanks. Note that 3.15.1 includes a fix for gcc 4.8.5.

@emillon emillon closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants