Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odoc rules do not compute the package version correctly #2083

Closed
rgrinberg opened this issue Apr 25, 2019 · 1 comment
Closed

Odoc rules do not compute the package version correctly #2083

rgrinberg opened this issue Apr 25, 2019 · 1 comment
Assignees
Labels

Comments

@rgrinberg
Copy link
Member

rgrinberg commented Apr 25, 2019

Here is how it's done in the odoc ruiles:

https://github.com/avsm/dune/blob/9f6daf146d92e02da73c50b4c6b6ebb32a077f6f/src/odoc.ml#L241-L246

Here is how it's done in the install rules:

https://github.com/avsm/dune/blob/9f6daf146d92e02da73c50b4c6b6ebb32a077f6f/src/install_rules.ml#L71-L96

Odoc should reuse the method form install rules for consistency.

@jonludlam from now on, I'll assign odoc issues in bulk to you if you don't mind.

@emillon
Copy link
Collaborator

emillon commented Jul 28, 2022

The difference has been removed in #2541. Now we use pkg.Package.version which sources from (version), (package (version)) or the VCS.

@emillon emillon closed this as completed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants