Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make install-libdir more repro #8341

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Aug 4, 2023

We modify the test so that the current opam prefix doesn't have an affect on the test itself. We do this by mocking up an opam prefix which is added to the env when a user does opam env.

This makes this test reproducible on Nix and also we avoid touching directories outside of the test.

We modify the test so that the current opam prefix doesn't have an
affect on the test itself. We do this by mocking up an opam prefix which
is added to the env when a user does `opam env`.

This makes this test reproducible on Nix and also we avoid touching
directories outside of the test.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter requested a review from rgrinberg August 4, 2023 16:07
@Alizter Alizter mentioned this pull request Aug 4, 2023
11 tasks
@Alizter Alizter marked this pull request as draft August 4, 2023 17:26
@Alizter
Copy link
Collaborator Author

Alizter commented Aug 4, 2023

Apparently not as repro as I thought.

@rgrinberg rgrinberg closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants