-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action to build monorepo bunch docker image #8500
Github action to build monorepo bunch docker image #8500
Conversation
07a9095
to
e948c57
Compare
I added this test because benchmarking infrastructure sometimes goes down and changes made to dune during these periods can break the monorepo benchmark without us realizing until much later. This test will build the docker image used to run the monorepo benchmark. |
I tried having the action upload the docker stages to a registry (
Didn't really expect this to work without configuration. Do we have a docker registry set up which the tests can access? |
I'm not aware of one. Let's ask Riku internally. |
Dune could use Docker Hub's Personal tier account as an open-source project. It even comes with a single private repository, which we could use for this purpose. Is 200 pulls per 6 hours sufficient for our purposes? |
Yep I think that will be fine. Once the account is made we just have to put the password in |
8837318
to
b8a4564
Compare
.github/workflows/workflow.yml
Outdated
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
- uses: whoan/docker-build-with-cache-action@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe v6 is the latest.
Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
b8a4564
to
1fce46d
Compare
|
||
monorepo_benchmark_test: | ||
name: Build monorepo benchmark docker image | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we think that this is a good idea? I am worried that if ubuntu-latest
switches to a new Ubuntu release, it'll potentially break down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly, but note that the dockerfile itself specifies a very specific version (of debian) and it's unlikely that when ubuntu gets updated it shouldn't affect how docker behaves.
No description provided.