Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action to build monorepo bunch docker image #8500

Merged

Conversation

gridbugs
Copy link
Collaborator

No description provided.

@gridbugs gridbugs force-pushed the github-action-build-monorepo-benchmark-image branch 3 times, most recently from 07a9095 to e948c57 Compare August 25, 2023 06:33
@gridbugs
Copy link
Collaborator Author

I added this test because benchmarking infrastructure sometimes goes down and changes made to dune during these periods can break the monorepo benchmark without us realizing until much later. This test will build the docker image used to run the monorepo benchmark.

@gridbugs
Copy link
Collaborator Author

I tried having the action upload the docker stages to a registry (ghcr.io) to speed up the test since otherwise each run will take about 30 minutes. I get this error:

denied: installation not allowed to Create organization package

Didn't really expect this to work without configuration. Do we have a docker registry set up which the tests can access?

@gridbugs gridbugs requested review from Alizter and rgrinberg August 25, 2023 07:35
@rgrinberg
Copy link
Member

rgrinberg commented Aug 28, 2023

Do we have a docker registry set up which the tests can access?

I'm not aware of one. Let's ask Riku internally.

@rikusilvola
Copy link
Contributor

Dune could use Docker Hub's Personal tier account as an open-source project. It even comes with a single private repository, which we could use for this purpose. Is 200 pulls per 6 hours sufficient for our purposes?

@gridbugs
Copy link
Collaborator Author

Is 200 pulls per 6 hours sufficient for our purposes?

Yep I think that will be fine. Once the account is made we just have to put the password in secrets.DOCKER_HUB_PASSWORD in the repo settings. I'll update the PR to use dockerhub instead of github as its registry.

@gridbugs gridbugs force-pushed the github-action-build-monorepo-benchmark-image branch from 8837318 to b8a4564 Compare August 29, 2023 04:55
steps:
- name: Checkout code
uses: actions/checkout@v3
- uses: whoan/docker-build-with-cache-action@v5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe v6 is the latest.

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
@gridbugs gridbugs force-pushed the github-action-build-monorepo-benchmark-image branch from b8a4564 to 1fce46d Compare August 30, 2023 01:27

monorepo_benchmark_test:
name: Build monorepo benchmark docker image
runs-on: ubuntu-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think that this is a good idea? I am worried that if ubuntu-latest switches to a new Ubuntu release, it'll potentially break down.

Copy link
Collaborator Author

@gridbugs gridbugs Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, but note that the dockerfile itself specifies a very specific version (of debian) and it's unlikely that when ubuntu gets updated it shouldn't affect how docker behaves.

@rgrinberg rgrinberg merged commit 0566d5c into ocaml:main Sep 7, 2023
@gridbugs gridbugs deleted the github-action-build-monorepo-benchmark-image branch October 11, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants