Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set OCAMLTOP_INCLUDE_PATH to %{toplevel}%? #15547

Closed
ghost opened this issue Dec 16, 2019 · 3 comments
Closed

Set OCAMLTOP_INCLUDE_PATH to %{toplevel}%? #15547

ghost opened this issue Dec 16, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Dec 16, 2019

Since 4.08.0, OCaml supports a new environment variable OCAMLTOP_INCLUDE_PATH to specify additional include directories for the toplevel. Setting this variable would allow scripts installed in %{toplevel}% to be available in the OCaml toplevel without the user manually adding %{toplevel}% to the include path in the toplevel or package authors manually installing toplevel scripts in %{lib_root}%/ocaml.

opam already sets OCAML_TOPLEVEL_PATH to %{toplevel}%, however this variable is only recognised by utop and not by the vanilla OCaml toplevel.

I propose to start setting the OCAMLTOP_INCLUDE_PATH variable in the ocaml package, and eventually stop setting the OCAML_TOPLEVEL_PATH one. Thoughts?

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove the stale label, or comment, or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Apr 21, 2020
@ghost
Copy link
Author

ghost commented Apr 21, 2020

This is a not a super important issue, but is quite simple and still seems worth doing to me.

@ghost
Copy link
Author

ghost commented May 21, 2020

@dra27 do you think this change would break anything? This seems like a simple to change to make and it would make the life of people who want to install toplevel scripts easier in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants