From 8bb48be79aa29b876edf3925c5e7d646fed719f3 Mon Sep 17 00:00:00 2001 From: David Allsopp Date: Wed, 26 May 2021 10:53:12 +0100 Subject: [PATCH] Display log line in OpamSystem.install on Windows too --- src/core/opamSystem.ml | 71 ++++++++++++++++++++---------------------- 1 file changed, 34 insertions(+), 37 deletions(-) diff --git a/src/core/opamSystem.ml b/src/core/opamSystem.ml index 79d26f735f8..050ccf4bba7 100644 --- a/src/core/opamSystem.ml +++ b/src/core/opamSystem.ml @@ -729,44 +729,41 @@ let install ?(warning=default_install_warning) ?exec src dst = let exec = match exec with | Some e -> e | None -> is_exec src in - begin - if Sys.win32 then - if exec then begin - let (dst, cygcheck) = - match classify_executable src with - `Exe _ -> - if not (Filename.check_suffix dst ".exe") && not (Filename.check_suffix dst ".dll") then begin - warning dst `Add_exe; - (dst ^ ".exe", true) - end else - (dst, true) - | `Dll _ -> - warning dst `Install_dll; + let perm = if exec then 0o755 else 0o644 in + log "install %s -> %s (%o)" src dst perm; + if Sys.win32 then + if exec then begin + let (dst, cygcheck) = + match classify_executable src with + `Exe _ -> + if not (Filename.check_suffix dst ".exe") && not (Filename.check_suffix dst ".dll") then begin + warning dst `Add_exe; + (dst ^ ".exe", true) + end else (dst, true) - | `Script -> - warning dst `Install_script; - (dst, false) - | `Unknown -> - warning dst `Install_unknown; - (dst, false) - in - copy_file_aux ~src ~dst (); - if cygcheck then - match OpamStd.Sys.is_cygwin_variant dst with - `Native -> - () - | `Cygwin -> - warning dst `Cygwin - | `CygLinked -> - warning dst `Cygwin_libraries - end else - copy_file_aux ~src ~dst () - else ( - let perm = if exec then 0o755 else 0o644 in - log "install %s -> %s (%o)" src dst perm; - copy_file_aux ~chmod:(fun _ -> perm) ~src ~dst () - ) - end + | `Dll _ -> + warning dst `Install_dll; + (dst, true) + | `Script -> + warning dst `Install_script; + (dst, false) + | `Unknown -> + warning dst `Install_unknown; + (dst, false) + in + copy_file_aux ~src ~dst (); + if cygcheck then + match OpamStd.Sys.is_cygwin_variant dst with + `Native -> + () + | `Cygwin -> + warning dst `Cygwin + | `CygLinked -> + warning dst `Cygwin_libraries + end else + copy_file_aux ~src ~dst () + else + copy_file_aux ~chmod:(fun _ -> perm) ~src ~dst () let cpu_count () = try