Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam admin should self-upgrade (as other commands do) #4318

Open
dra27 opened this issue Aug 19, 2020 · 2 comments
Open

opam admin should self-upgrade (as other commands do) #4318

dra27 opened this issue Aug 19, 2020 · 2 comments
Assignees
Labels

Comments

@dra27
Copy link
Member

dra27 commented Aug 19, 2020

opam admin --help shows OPAMNOSELFUPGRADE in ENVIRONMENT VARIABLES but doesn't actually support it, or the --no-self-upgrade.

For consistency, global options should probably be available globally 🙂 It should just be a matter of moving the wrapping in OpamCommands.global_options into OpamArg.global_options.

@dra27 dra27 added the AREA: UI label Aug 19, 2020
@dra27 dra27 added this to the 2.1.0~rc milestone Aug 19, 2020
@dra27 dra27 modified the milestones: 2.1.0~rc, 2.1.0~beta5 Jan 7, 2021
@dra27 dra27 self-assigned this Feb 5, 2021
@dra27
Copy link
Member Author

dra27 commented Mar 11, 2021

Having looked at this in more detail, this would entail a bigger change of behaviour. At the moment, all commands except opam admin do self-upgrading (and so have --no-self-upgrade). It obviously makes no sense to add --no-self-upgrade to opam admin without also making it do the self-upgrade. However, that's a less-obvious change, so I'm going to bump this to next.

@dra27 dra27 changed the title opam admin should support --no-self-upgrade opam admin should self-upgrade (as other commands do) Mar 11, 2021
@dra27 dra27 modified the milestones: 2.1.0~rc, 2.2.0~alpha Mar 11, 2021
@dra27
Copy link
Member Author

dra27 commented Mar 11, 2021

The change itself is not difficult, though - and it can also be guarded with CLI versioning!

@dra27 dra27 removed this from the 2.2.0~alpha milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant