Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPDX format linter should not allow case insensitive operators #4613

Closed
kit-ty-kate opened this issue Mar 24, 2021 · 2 comments · Fixed by #4768
Closed

SPDX format linter should not allow case insensitive operators #4613

kit-ty-kate opened this issue Mar 24, 2021 · 2 comments · Fixed by #4768
Labels
AREA: UI KIND: BUG
Milestone
2.2.0~alpha

Comments

@kit-ty-kate
Copy link
Member

The SPDX format checked for by opam lint explicitly says that:

License expression operators (AND, OR and WITH) should be matched in a case-sensitive manner.

see: https://spdx.github.io/spdx-spec/appendix-IV-SPDX-license-expressions/

opam allows <license> with <exception> but it should not be the case
kit-ty-kate referenced this issue in alan-j-hu/llvm-dune Mar 24, 2021
@kit-ty-kate
Add Gordon Henriksen as one of the original authors
b9d81c7
@dra27
Copy link
Member

dra27 commented Jul 2, 2021

Cross-referencing #4598

@kit-ty-kate
Copy link
Member Author

The syntax for having multiple license currently accepted is license: ["license1" "license2"] where it should probably be license: "license1 AND license2)"

@dra27 dra27 added the AREA: UI label Jul 16, 2021
@kit-ty-kate kit-ty-kate linked a pull request Jul 29, 2021 that will close this issue
opam lint: Add support for the full SPDX license expression when checking the license #4768
Merged
@kit-ty-kate kit-ty-kate added this to the 2.2.0~alpha milestone Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AREA: UI KIND: BUG
Projects
None yet
Milestone
2.2.0~alpha
2 participants
@kit-ty-kate @dra27