Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-detect switch; support relative path #296

Closed
vogler opened this issue Jul 23, 2020 · 2 comments · Fixed by #445
Closed

auto-detect switch; support relative path #296

vogler opened this issue Jul 23, 2020 · 2 comments · Fixed by #445

Comments

@vogler
Copy link

vogler commented Jul 23, 2020

Is there something speaking against automatically selecting the opam switch by default?
Taking the result of opam switch show for the currently opened vscode workspace should be the right choice 99% of the time and if it's not, it's shown in the status bar and easy to change.

Another issue: I wanted to share my .vscode/settings.json but ocaml.sandbox.switch does not seem to support relative paths.

@mnxn
Copy link
Collaborator

mnxn commented Jul 23, 2020

Using opam switch show for toolchain selection can certainly be implemented.

I think that the sandbox configuration should be revisited to make it easier to share. That would include relative paths and possibly a separate file like how c_cpp_properties.json is used by the C/C++ extension .

@mnxn mnxn added type: feature New feature or request type: improvement and removed type: feature New feature or request labels Jul 23, 2020
@mnxn mnxn self-assigned this Aug 13, 2020
@mnxn mnxn added this to the 0.9.0 milestone Aug 15, 2020
@mnxn mnxn removed their assignment Sep 23, 2020
@mnxn mnxn removed this from the next milestone Oct 20, 2020
@mnxn
Copy link
Collaborator

mnxn commented Nov 7, 2020

Regarding your second point, configuration files have been made a bit more portable with #424. The extension will now use workspace folder placeholder variables by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants