You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
In another library I was working on, I figured a very seamless way to offer a boolean toggle is to just have a function that you pass in true/false.
My proposal is changing collectWindowErrors to be a function instead of boolean switch like: TraceKit.collectWindowErrors(false) Then, when you turn off window errors, we also restore the previous window.onerror handler, when you turn them on, we restore our handler.
Any tweaks or good to go?
The text was updated successfully, but these errors were encountered:
In another library I was working on, I figured a very seamless way to offer a boolean toggle is to just have a function that you pass in true/false.
My proposal is changing
collectWindowErrors
to be a function instead of boolean switch like:TraceKit.collectWindowErrors(false)
Then, when you turn off window errors, we also restore the previous window.onerror handler, when you turn them on, we restore our handler.Any tweaks or good to go?
The text was updated successfully, but these errors were encountered: