Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Remove remote fetching and analyzing? #25

Closed
devinrhode2 opened this issue Jan 8, 2013 · 4 comments
Closed

Remove remote fetching and analyzing? #25

devinrhode2 opened this issue Jan 8, 2013 · 4 comments

Comments

@devinrhode2
Copy link

I don't like the idea of TraceKit making a request for my js file to provide lines of context when it's almost no different than just getting the straight line number of the error.

I'm proposing we remove all operations dealing with requesting a remote file and analyzing it.

Related to #11, testing becomes tricky

@devinrhode2
Copy link
Author

What do you think @airportyh?

@airportyh
Copy link

But from what I understand, remote source fetching is a big component of TraceKit. It is what makes stacktraces work in IE, for example, which I think is actually very nifty.

@airportyh
Copy link

Oh, and I just realized this won't help the fact that evaling breaks stacktraces - no location or lineno info.

@occ
Copy link
Owner

occ commented Jan 11, 2013

Remote fetching is an important part of tracekit. I don't think removing it would be a good idea. I do support having/improving the "do not fetch" flag though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants