Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi choice options on chips #1092

Merged
merged 8 commits into from
Mar 25, 2024
Merged

Conversation

lpeil
Copy link
Contributor

@lpeil lpeil commented Mar 25, 2024

Description

Create multi options to chips component

Fixes # (issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Screenshots (if appropriate):

Checklist:

  • I have read the CONTRIBUTING document
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • My changes work in Chrome, Edge, and Firefox
  • I have made corresponding changes to the documentation (if appropriate)
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed

@lpeil lpeil requested a review from a team March 25, 2024 12:54
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (23bd270) to head (b9701bd).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1092   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        61    +2     
  Lines         1159      1251   +92     
  Branches       370       415   +45     
=========================================
+ Hits          1159      1251   +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpeil lpeil merged commit fc239e5 into master Mar 25, 2024
11 of 13 checks passed
@lpeil lpeil deleted the feat/chips-multichoice branch March 25, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants