Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update alert #1115

Merged
merged 27 commits into from
Jul 2, 2024
Merged

feat: update alert #1115

merged 27 commits into from
Jul 2, 2024

Conversation

danimuller20
Copy link
Contributor

Description

Updates alert component layout and styles.

Fixes # (issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Screenshots (if appropriate):

Checklist:

  • I have read the CONTRIBUTING document
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • My changes work in Chrome, Edge, and Firefox
  • I have made corresponding changes to the documentation (if appropriate)
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed

@danimuller20 danimuller20 self-assigned this Jun 26, 2024
@danimuller20 danimuller20 marked this pull request as ready for review June 26, 2024 15:04
@danimuller20 danimuller20 changed the title Feat: update alert feat: update alert Jun 26, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (23bd270) to head (76ed6b9).
Report is 47 commits behind head on master.

Current head 76ed6b9 differs from pull request most recent head 64c3ee9

Please upload reports for the commit 64c3ee9 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #1115      +/-   ##
===========================================
- Coverage   100.00%   99.62%   -0.38%     
===========================================
  Files           59       63       +4     
  Lines         1159     1345     +186     
  Branches       370      466      +96     
===========================================
+ Hits          1159     1340     +181     
- Misses           0        5       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jul 2, 2024

@danimuller20 danimuller20 merged commit 3386652 into master Jul 2, 2024
9 of 11 checks passed
@danimuller20 danimuller20 deleted the feat/update-alert branch July 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants