Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lodash import #613

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix: lodash import #613

merged 2 commits into from
Jun 3, 2024

Conversation

mdonnalley
Copy link
Contributor

Fixes #612

mshanemc
mshanemc approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that TS allowed that

@mshanemc
Copy link
Member

mshanemc commented Jun 3, 2024

QA notes:
link into sf, switch to latest

run SF_FORCE_VERSION_CACHE_UPDATE=true SF_NEW_VERSION_CHECK_FREQ=1 SF_NEW_VERSION_CHECK_FREQ_UNIT=milliseconds sf version a few times

✅ [no warning]

sf update --version 2.35.1

✅ I see warnings

switch to nightly
✅ no warning

@mshanemc mshanemc merged commit acbbd10 into main Jun 3, 2024
10 checks passed
@mshanemc mshanemc deleted the mdonnalley/fix-lodash-import branch June 3, 2024 15:52
@2ndshadow 2ndshadow mentioned this pull request Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Igorgro Igorgro Igorgro approved these changes

@mshanemc mshanemc mshanemc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message about available update is not shown
3 participants
@mdonnalley @mshanemc @Igorgro