-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh request: Implement async read/write traits #30
Comments
(Converting via tokio's asyncfd support isn't possible today, because there is no anonymous Pipe layer today, only unix fd's and windows NamedPipes. Another route forward would be to switch to namedpipes. https://docs.rs/tokio/latest/tokio/io/unix/struct.AsyncFd.html?search=asyncfd |
imo there's tokio-pipe for tokio |
@NobodyXu oh, thank you, will give that a go, but its not a like-for-like drop in as I can see: it requires unsafe and bouncing through asrawfd / from rawfd - which os_pipe can be used this way as well - nothing like the ergonomics of os_pipe for std::process:Command. |
@rbtcollins which function is missing? There's a Do you need It should be very easy to add that support to the crate. |
e.g. AsyncRead, AsyncBufRead etc. This would require a dependency on futures, so perhaps a feature flag. Wouldn't need to bring in tokio or anything large, and as far as I can tell aligns well with the intent of a mid-layer crate.
The text was updated successfully, but these errors were encountered: