Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log option parameter #190

Merged
merged 7 commits into from
Oct 15, 2020
Merged

feat: log option parameter #190

merged 7 commits into from
Oct 15, 2020

Conversation

romanbalayan
Copy link
Contributor

No description provided.

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Oct 15, 2020
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, it only requires a small change to get to the 100% code coverage. Thank you 💐

Because I show this live on raise.dev/hacktoberfest, I'll go ahead and do the changes myself so I can show some other things :)

Update: here is the video: https://www.twitch.tv/videos/771366287

src/index.ts Outdated Show resolved Hide resolved
test/index.test.ts Outdated Show resolved Hide resolved
@gr2m gr2m changed the title Feat log option parameter feat: log option parameter Oct 15, 2020
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@gr2m gr2m merged commit d4062fb into octokit:master Oct 15, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@romanbalayan
Copy link
Contributor Author

Hey @gr2m!

Watched the whole twitch video, and thank you for the shout out! Super interesting workflow you have on how you are maintaining Octokit. I'm a big fan of automation myself, and the process you have is really insightful. Hopefully, I get to contribute on other Octokit projects as well! Thanks a lot!

@romanbalayan romanbalayan deleted the feat-log-option-parameter branch October 16, 2020 10:20
jefferycline1 pushed a commit to jefferycline1/auth-app.js that referenced this pull request Jul 5, 2021
Co-authored-by: Roman Balayan <roman.balayan@paymaya.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants