feat: pass all strategy options to auth factory
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
force-pushed
the
pass-all-strategy-options-to-auth-factory
branch
from
5c239b1
to
216629b
Compare
gr2m
force-pushed
the
pass-all-strategy-options-to-auth-factory
branch
from
c37564a
to
08cfd69
Compare
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any extra options are passed to the strategy options, they will be passed through to the
factorymethod inauth({ type: "installation", factory }). This makes sure that theoctokitandoctokitOptionsoptions that@octokit/corenow passes automatically since octokit/core.js#233 will be passed to thefactoryfor easier constructon of a newoctokitinstance