Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): throw Error when auth type is not a valid one #249

Merged
merged 5 commits into from
Feb 3, 2021
Merged

feat(auth): throw Error when auth type is not a valid one #249

merged 5 commits into from
Feb 3, 2021

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Feb 2, 2021

📝 Summary

throw Error when auth type is not a valid one

⛱ Motivation and Context

Fix #216

@oscard0m oscard0m added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only labels Feb 2, 2021
oscard0m
oscard0m commented Feb 2, 2021
View reviewed changes
test/index.test.ts Outdated Show resolved Hide resolved
@oscard0m oscard0m mentioned this pull request Feb 2, 2021
Closed
@oscard0m oscard0m marked this pull request as ready for review February 3, 2021 17:02
@oscard0m oscard0m requested a review from gr2m February 3, 2021 17:15
gr2m
gr2m approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m added Type: Feature New feature or request and removed Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only labels Feb 3, 2021
@gr2m gr2m merged commit ffaefb5 into master Feb 3, 2021
@gr2m gr2m deleted the throw-error-when-auth-type-is-invalid branch February 3, 2021 17:24
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dependabot dependabot bot mentioned this pull request Mar 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw error of unrecognized type in .auth({ type })
2 participants
@oscard0m @gr2m