Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 feat(typescript): discriminate resolve type of auth(options) based on options #270

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🚧 feat(typescript): discriminate resolve type of auth(options) based on options #270

wants to merge 2 commits into from

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Mar 31, 2021 •
edited
Loading

This pull request only adds a failing test so far. Once it's implement it fixes #268

@gr2m gr2m added Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only labels Mar 31, 2021
@gr2m gr2m mentioned this pull request Mar 31, 2021
Open
@gr2m gr2m self-assigned this Apr 22, 2021
@gr2m gr2m removed their assignment Apr 22, 2021
@gr2m gr2m changed the title feat(typescript): discriminate resolve type of auth(options) based on options 🚧 feat(typescript): discriminate resolve type of auth(options) based on options Apr 22, 2021
@gr2m
Copy link
Contributor Author

gr2m commented Apr 22, 2021

ping @jeffwilcox would you still like to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS: having to cast to specific Authentication types since 3.3.0
1 participant
@gr2m