Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add installationId to InstallationAccessTokenAuthentication #331

Merged
merged 2 commits into from
Oct 14, 2021
Merged

fix(types): add installationId to InstallationAccessTokenAuthentication #331

merged 2 commits into from
Oct 14, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Oct 14, 2021 •
edited
Loading 

const auth = createAppAuth({
  appId: 1,
  privateKey: "-----BEGIN PRIVATE KEY-----\n...",
  clientId: "lv1.1234567890abcdef",
  clientSecret: "1234567890abcdef12341234567890abcdef1234",
});

// Retrieve installation access token
const installationAuthentication = await auth({
  type: "installation",
  installationId: 123,
});

installationAuthentication.installationId is set, but the current types don't reflect that. This pull request fixes the problem

@gr2m gr2m added Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only labels Oct 14, 2021
@gr2m gr2m merged commit cf72564 into master Oct 14, 2021
@gr2m gr2m deleted the InstallationAccessTokenData-type-fix branch October 14, 2021 00:43
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gr2m