-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v7 #580
Conversation
BREAKING CHANGE: package is now ESM
BREAKING CHANGE: remove type "oauth" that was previously deprecated
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
There's 2 tests that are failing, I don't know why |
It seems the timeout error is intermittent. It's passing on some of the runs |
There is only one commit that has "passed checks" because the tests did not run on that commit |
I spent some time trying to figure it out. I remove the custom sinon fake timers and use Jest's own instead. But things are still not working reliably. I think this is more of a jest problem than a problem with our code or tests. I really don't like using Jest for testing because it does to much "magic". I feel it's made for front-end testing and it's great for that, but for backend, I'd either use |
I still see the tests that use the |
I guess the CI doesn't like it 🤷🏼 shall we just skip the two tests that cause trouble to unblock v7 and get back to it later? |
Fine with me |
…rs to advance time" This reverts commit 33c0aec.
…ines will be replaced
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: package is now ESM
BREAKING CHANGE: remove type "oauth" that was previously deprecated