Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All instances of master in tests should be checked and updated to main #2483

Closed
JonruAlveus opened this issue Jul 14, 2022 · 2 comments · Fixed by #2511
Closed

All instances of master in tests should be checked and updated to main #2483

JonruAlveus opened this issue Jul 14, 2022 · 2 comments · Fixed by #2511
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@JonruAlveus
Copy link
Collaborator

Given the default branch name is now main, a number of integration tests fail to run because they are looking for the master branch. We should check all instances of master and update to main if appropriate.

@JonruAlveus
Copy link
Collaborator Author

@nickfloyd @timrogers I've made a start on this (see attached PR). As I'm going through the integration tests I'm noticing a few issues, as I can't actually run half of the tests. Are you happy if I extend this and:

  • Change attributes for organisation tests from IntegrationTest to OrganizationTest
  • Change constructors to only provide the client and repository and having usings in each test to create the test specific resources
    • Changing this because I don't have an organisation to test against and I can't run the tests if the constructor creates the organisation data for tests which don't use organisations
  • (Re)merging free and organisation tests where appropriate so they can be kept under the same class if they do the same thing
  • Fixing namespaces
    • What's the policy here? Namespaces follow folder structure or everything has a common namespace? At the moment there's a mixture of common namespace, folder namespace and no namespace.

Cheers!

@JonruAlveus
Copy link
Collaborator Author

See #2492 for possibly a better way of doing these tests with base classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
2 participants