Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Allow managing Copilot for Business seats with new CopilotClient #2750

Closed
1 task done
dylan-asos opened this issue Jul 19, 2023 · 5 comments · Fixed by #2826
Closed
1 task done

[FEAT]: Allow managing Copilot for Business seats with new CopilotClient #2750

dylan-asos opened this issue Jul 19, 2023 · 5 comments · Fixed by #2826
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@dylan-asos
Copy link
Contributor

Describe the need

A new API is available (in beta) that allows managing Copilot for Business license allocations.

https://docs.github.com/en/rest/copilot/copilot-for-business?apiVersion=2022-11-28

Implement the API methods in a new CopilotClient class, allowing integration opportunities to manage Copilot setup.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dylan-asos dylan-asos added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jul 19, 2023
@nickfloyd nickfloyd added the Status: Up for grabs Issues that are ready to be worked on by anyone label Jul 19, 2023
@nickfloyd
Copy link
Contributor

@dylan-asos Thanks for the call out here. This does make me think that we need some way to indicate that the underlying APIs for a given set of SDKs are beta - so that when they do change it's an understood "breaking change" cc: @kfcampbell

Related: octokit/octokit.js#2492

@dylan-asos
Copy link
Contributor Author

I'll probably pick this up as have a vested interest. Let me know if any thoughts around the beta/breaking change element to this.

Any way to have a vNext/Beta path + publish a pre-release version of the nuget package? e.g. 7.0.1-beta. Or, trying to keep that overhead out of the process and prefer to keep everything on stable semver?

@kfcampbell
Copy link
Member

My vote would be to follow the Microsoft Nuget pre-release guidelines and then detail the beta changes in our release notes. If we wanted to get more specific, perhaps we could explore using custom attributes to mark specific functions, though I don't think that's necessary at this point.

@nickfloyd nickfloyd added the hacktoberfest Issues for participation in Hacktoberfest label Sep 21, 2023
@dylan-asos
Copy link
Contributor Author

Have started work - sorry it's been a bit slow coming.

Branch over here -> https://github.com/octokit/octokit.net/compare/main...dylan-asos:octokit.net:feature/copilot?expand=1

Going to get assign/remove/search and top level billing status implemented first, then will come back and do the team assignment work on a second pass. I think these methods would give people some immediate value.

PR hopefully this week.

@dylan-asos
Copy link
Contributor Author

Draft PR for any early feedback @kfcampbell @nickfloyd.

@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants